Update to 8.1 stable release#1227
Conversation
|
It seems that in case of PHP 8.0 the RC -> stable transition was done manually here. So the bot likely doesn't support that case. Your PR should help. :-) |
|
This might need to be adjusted, though I have no clue what this file is about. |
|
good catch @enumag! that script seems to be for generating this file: https://github.com/docker-library/official-images/blob/master/library/php I think I've updated it correctly |
|
As 8.1 release missing until now - I'm not into it if this PR would really solve it, or if it is the full/right way. Anyway would be nice to have 8.1.0 released as images ready, as we depend on it for our testing. Not sure who is maintainer on this repository, but looking through the commits maybe @yosifkit ? |
|
@sbuerk It's the weekend, let the maintainers also enjoy the weekend how they prefer :). I get that you're excited and want an 8.1 stable image available as soon as possible. But generally, these images lag up to a week behind. Also IMHO it might make sense to have #1226 merged in first so we don't end up with a single outdated Alpine 3.13 image of 8.1. |
|
@WyriHaximus Eh sry .. you are right. (Really it's weekend ?!) I should check my time feeling. |
|
@sbuerk Hey I get it, we're all tired, we all had our ability to sense time passing distorted, we're all excited about all the features 8.1 brings. The only thing I'm asking is to let maintainers take their rest when they want to without getting pinged, and I'm just assuming the weekend here 😅, so they can go in (well) rested and review PR's like these. |
|
@WyriHaximus You are absolutly right, and reading my own post myself I'm feeling uncomfortable with it - and I'm regret it. It was too pressing, so please take my apology. Very gratefull for this repo and the pre-work. Just slipped in in a 5 min slot and "ping there" before going on with own work and so forth .. which is no excuse !!! We are "green" wit RC6 , and in generelly it should not change much. Was quick shot. Hopefully you and the maintainer(s) can take the excuse. |
Agreed -- I've merged #1226 now (and plan to rebase this after I get through more long Thanksgiving weekend email backlog, if @mallardduck doesn't beat me to it 😇 ❤️). |
|
@tianon - i'll get the rebase done RN |
780aec5 to
d233fa9
Compare
|
Nice, thanks! 👍 |
Changes: - docker-library/php@8447ef3: Update to 8.1 stable release (docker-library/php#1227) - docker-library/php@ba79418: Merge pull request docker-library/php#1226 from J0WI/alpine-3.15 - docker-library/php@0c60516: Alpine 3.15
|
Am I missing something or what but looks like the images with Alpine 3.15 are missing |
|
Never mind, I have jumped the gun, looks like the images are still building at the time of writing this comment. https://doi-janky.infosiftr.net/job/multiarch/job/amd64/job/php/ |
|
Is there some way to change the pipelines to build the amd64 and 386 images first? 🤔 It makes no sense that it's starting from the least needed images. |
|
|
@pherum please see comments #1227 (comment) and #1227 (comment). |
@enumag This only happens for the first image of a new minor/major. Honestly, I really doubt changing all that is worth the ~8 hours you get to use the new major/minor earlier once per year. |
|
Each architecture queue is completely independent -- other amd64/i386
builds are what delay amd64/i386 builds (we don't ever have an amd64 build
waiting for a mips64le build, for example).
|
7 participants
Just noticed after doing this that there seems to be a bot that might be making this happen. So please disregard if it's just a matter of time for that to happen to get the 8.1 images updated to release.